Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701982 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mschwendt@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mschwendt@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Michael Schwendt <mschwendt@xxxxxxxxx> 2011-05-06 16:30:03 EDT --- > License: GPLv3 The included file COPYING is GPLv2. The source files include GPLv2 headers. Upstream web page says "GPLv3", so please ask them to clarify. > Name: osm-gps-map > Group: Development/Libraries The group for library base packages typically is "System Environment/Libraries". > Summary: A Gtk+ widget for displaying OpenStreetMap tiles I still think we should get rid of even more "A", "An", "The" articles at the beginning of these summaries. It makes a better reading during installation and in package installer tools. Your summary for the -devel package also doesn't start with "The". ;) > %description > A Gtk+ widget (and Python bindings) ... The Python bindings are not included in this package, but in a separate one. > %doc AUTHORS COPYING README What about file NEWS? > %files devel > %doc COPYING It is not necessary to duplicate that file in the subpackage. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing > make %{?_smp_mflags} Consider using make V=1 %{?_smp_mflags} so the build output is less silent and e.g. shows full compiler flags. > osm-gps-map v0.7.3 > Prefix............... : /usr > libsoup.............. : 2.4 > Introspection support : no > gtk-doc documentation : no $ grep -i introspec build.log checking for gobject-introspection... no Introspection support : no -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review