Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=663925 --- Comment #7 from Takanori MATSUURA <t.matsuu@xxxxxxxxx> 2011-05-06 11:38:12 EDT --- Thank you for reviewing. Spec URL: http://t-matsuu.sakura.ne.jp/mock/autoconf-archive/autoconf-archive.spec SRPM URL: http://t-matsuu.sakura.ne.jp/mock/autoconf-archive/autoconf-archive-2011.04.12-0.fc14.src.rpm (In reply to comment #5) > [!] : SHOULD - SourceX / PatchY prefixed with %{name}. > Source0: > ftp://ftp.gnu.org/gnu/autoconf-archive/autoconf-archive-%{version}.tar.xz > (autoconf-archive-%{version}.tar.xz) Fixed. Thanks. > [!] : SHOULD - Latest version is packaged. Updated to 2011.04.12. > [!] : SHOULD - Scriptlets must be sane, if used. Fixed %post and %preun scriptlets. > [?] : SHOULD - Packages should try to preserve timestamps of original > installed files. Added INSTALL="install -p" for make install. > Issues: > [!] : MUST - Spec file lacks Packager, Vendor, PreReq tags. > this can be ignored, I think I never added Packager tag in the spec file. I'm afraid it has been added by your setting. > [!] : MUST - License field in the package spec file matches the actual license. > Does COPYING.EXCEPTION need to be included? > Some of the files in build-aux imply GPLv3+ License field has been updated to "GPLv3+ with exceptions". > [!] : MUST - Package installs properly. > Message when installing on F14: > > install-info: Is a directory for /usr/share/info Fixed %post and %preun scriptlets. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review