Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700571 --- Comment #4 from Martin Cermak <mcermak@xxxxxxxxxx> 2011-05-05 10:02:55 EDT --- I belive all issues are fixed now in spindown-0.4.0-2: Spec URL: http://www.physics.muni.cz/~cermak/spindown-0.4.0-2/spindown.spec SRPM URL: http://www.physics.muni.cz/~cermak/spindown-0.4.0-2/spindown-0.4.0-2.fc14.src.rpm Patch0 URL: http://www.physics.muni.cz/~cermak/spindown-0.4.0-2/spindown-0.4.0-initscript.patch Patch1 URL: http://www.physics.muni.cz/~cermak/spindown-0.4.0-2/spindown-0.4.0-Makefile.patch Patch2 URL: http://www.physics.muni.cz/~cermak/spindown-0.4.0-2/spindown-0.4.0-iniparser.patch All changes are described in the changelog. Because the project is not under version control yet, I'm creating patches against pure sources. For this reason patches changed (for example [1] differs from [2]). Also I'm omitting the licence change announcement on fedora-devel-list in this case. Here are rpmlint results: + rpmlint spindown.spec spindown.spec: W: invalid-url Source0: http://spindown.googlecode.com/files/spindown-0.4.0.tar.gz HTTP Error 404: Not Found 0 packages and 1 specfiles checked; 0 errors, 1 warnings. + rpmlint spindown-0.4.0-2.fc14.src.rpm spindown.src: W: spelling-error %description -l en_US sg -> SG, chg, cig spindown.src: W: spelling-error %description -l en_US hdparm -> hardpan, harmed, Parma spindown.src: W: spelling-error %description -l en_US swappable -> trappable, mappable, unflappable spindown.src: W: spelling-error %description -l en_US hda -> had, hd, ha spindown.src: W: spelling-error %description -l en_US sdb -> sd, sb, db spindown.src: W: invalid-url Source0: http://spindown.googlecode.com/files/spindown-0.4.0.tar.gz HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 6 warnings. + rpmlint spindown-debuginfo-0.4.0-2.fc14.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. + rpmlint spindown-0.4.0-2.fc14.x86_64.rpm spindown.x86_64: W: spelling-error %description -l en_US sg -> SG, chg, cig spindown.x86_64: W: spelling-error %description -l en_US hdparm -> hardpan, harmed, Parma spindown.x86_64: W: spelling-error %description -l en_US swappable -> trappable, mappable, unflappable spindown.x86_64: W: spelling-error %description -l en_US hda -> had, hd, ha spindown.x86_64: W: spelling-error %description -l en_US sdb -> sd, sb, db spindown.x86_64: W: no-manual-page-for-binary spindownd 1 packages and 0 specfiles checked; 0 errors, 6 warnings. The package does not explicitly require sg3_utils because custom power management binaries (like sg_start or hdparm) can be used. I also performed sanity testing of the package on a machine with multiple disks. ------------------- [1] http://www.physics.muni.cz/~cermak/spindown-0.4.0-2/spindown-0.4.0-Makefile.patch [2] http://www.physics.muni.cz/~cermak/spindown/spindown-0.4.0-Makefile.patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review