Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=702277 Petr Sabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Petr Sabata <psabata@xxxxxxxxxx> 2011-05-05 08:04:40 EDT --- (In reply to comment #2) > (In reply to comment #1) > > NOTES: > > ------ > > Package should Require perl(Encode), perl(Exporter) and perl(File::Spec). Those > > are 'required' in the module but not caught by RPM. > > Fixed in -2. Looks okay. > > > Additionally, BuildRoot and its cleaning is no longer needed and should be > > removed. The same applies to the %defattr macro. > > These are needed for EPEL-4/5 compatibility; I intend to build the package for > all current target releases. Fine with me. > > Spec URL: > http://subversion.city-fan.org/repos/cfo-repo/perl-Digest-MD5-File/branches/fedora/perl-Digest-MD5-File.spec > > SRPM URL: > http://www.city-fan.org/~paul/extras/perl-Digest-MD5-File/perl-Digest-MD5-File-0.07-2.fc16.src.rpm Approving. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review