Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684835 --- Comment #6 from VÃt Ondruch <vondruch@xxxxxxxxxx> 2011-05-04 07:38:08 EDT --- * the line "mkdir -p %{buildroot}%{_bindir}" in %install section is duplicated. * "support" folder content - If I admit that support folder has some meaning for the original gem, it has not much sense on Fedora. - If I admit the Folder would be on Fedora, it should contain up-to-date content, e.g. the RPM spec file should be the same I am currently reviewing, but I am afraid you can never ever achieve it. - The easiest solution would be to delete it IMO. > * Deleting the %{_builddir} > - It is bad practice to delete %{_builddir} in installation step. It is not > harmful in this particular case, but once there would be binary extensions > it may cause troubles. This is coming from Ruby guidelines: > > "Finally at %install stage the whole tree under the directory created at %prep > stage should be copied (not moved) to under %{buildroot}%{gemdir}. > > When all tree under the directory created at %prep stage is moved to under > %{buildroot}, find_debuginfo.sh will complain that the corresponding source > files are missing." I pointed this once but I have to stress it again. Please, do not delete anything in %{_builddir}, unless you have very good reason. This time you are not exactly deleting but moving and the result might be the same. Moreover, the documentation is not generated due to "move" instead of "copy" -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review