Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693608 --- Comment #4 from Michael Schwendt <mschwendt@xxxxxxxxx> 2011-05-03 05:00:45 EDT --- > you're reaching in and modifying another package's username. Already using the same special user/group as another package isn't entirely nice and also isn't best practice security-wise (even if apparently it just tries to access nagios-plugins). https://fedoraproject.org/wiki/Packaging:UsersAndGroups > %attr(2755,nagios,icinga-cmd) %{_localstatedir}/icinga/rw/ Along the same lines, the following is also going too far: > Provides: nagios "nagios" is not a package capability, but the name of an existing package in the collection. Even if "icinga" has started as a fork of nagios, it must not disturb the package namespace of nagios and must not claim that it provides "nagios". > %package gui > ... > Requires: %{name}-doc Caution! A strict dependency on a documentation package asks for a rationale in the spec file just like other explicit dependencies: https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires Note that %doc files may be absent with --excludedocs installs, so either the documentation really is required by the -gui pkg at run-time, or it may be optional. What is it? Looking at the %files tree, currently the -gui package provides a directory that is needed by the -doc package. Same for the -api package. https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership > %package doc > Summary: documentation %{name} > Group: Applications/System Cut'n'paste error. Not the appropriate group. > %prep > %setup -qn %{name}-%{version} "-n %{name}-%{version}" is the default. > %config(noreplace) %{_sysconfdir}/icinga/objects/commands.cfg > %{_libdir}/icinga/cgi https://fedoraproject.org/wiki/Packaging:UnownedDirectories There could be more unowned directories. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review