[Bug 608319] Review Request: memaker - An avatar creator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=608319

Martin Gieseking <martin.gieseking@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking@xxxxxx

--- Comment #8 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-05-01 03:10:17 EDT ---
(In reply to comment #7)
> Please replace all occurences of the application name in the spec with %{name}.

That's optional and only useful in particular cases where the package name is
directly related to another entry in the spec file, e.g. the name of the
tarball.
Using %{name} in %install or %files is not required because there's no benefit
of doing so. If you want to use it there anyway, it should be consistent,
though (no mix between %{name} and the plain name string). 


> Wouldn't it be better to use the "install" command instead of cp, especially to
> keep timestamps?

cp -a preserves the timestamps too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]