Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701031 --- Comment #3 from Deji Akingunola <dakingun@xxxxxxxxx> 2011-04-30 13:33:18 EDT --- (In reply to comment #1) > Please use macros consistently and as many as possible, as follows: > > URL: https://launchpad.net/%{name} > Source0: > http://launchpad.net/%{name}/0.7/%{version}/+download/%{name}-%{version}.tar.gz > > %{_bindir}/%{name} > %{_mandir}/man1/%{name}.* > %{_sysconfdir}/xdg/autostart/%{name}.desktop > > It's not needed to provide a https link to the homepage, http also works and > leads to the https page anyway. > > The ChangeLog is empty, should be dropped from %docs. > > Please add a period after the description. > > You have to drop glib2-devel and gettext from BuildRequires. They are recursive > dependencies of gtk2-devel and intltool, respectively. I have dropped the empty ChangeLog file, replace the https link with the http one and put the period at the end of the description. I believe the rest if OK. Spec URL: http://deji.fedorapeople.org/zeitgeist-datahub.spec SRPM URL: http://deji.fedorapeople.org/zeitgeist-datahub-0.7.0-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review