Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700815 --- Comment #5 from Kalev Lember <kalev@xxxxxxxxxxxx> 2011-04-29 14:47:53 EDT --- Thanks for taking the review, Erik! (In reply to comment #3) > In your spec you're using a libtool hack to make this package build. In my > attempt I've used a different approach for this issue which is a more generic > solution to this problem and also is upstreamable: > http://svn.openftd.org/svn/fedora_cross/mingw-gtk3/gtk3-win32-libtool-fix.patch > Please consider using this patch Sounds like a good approach. Can you submit it upstream? Anyway, for now I think it's easier to maintain the lt_cv_deplibs_check_method override than patching both Makefile.am and and Makefile.in and worrying about rebasing the patch with each new upstream release. It would all change of course if you managed to get the patch upstreamed, which I fully support :-) > Is the PATH override really necessary to get this package build? Good catch, I don't think the override is really needed. * Fri Apr 29 2011 Kalev Lember <kalev@xxxxxxxxxxxx> - 3.0.9-2 - Removed an unneeded PATH override (#700815) Spec URL: http://kalev.fedorapeople.org/mingw32-gtk3.spec SRPM URL: http://kalev.fedorapeople.org/mingw32-gtk3-3.0.9-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review