Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-channel-phpunit - Add phpunit channel to pear Alias: channel-phpunit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220862 ------- Additional Comments From Fedora@xxxxxxxxxxxxxxxxx 2006-12-29 12:40 EST ------- After IRC meeting, all is OK. Build fine, and allow the build of new php-pear-PHPUnit in mock. REVIEW * no source files * package meets naming and packaging guidelines (no special guideline for channels). * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible (BSD). * BuildRequires are proper. * %clean is present. * package builds in mock (development). * package installs properly * rpmlint : W: php-channel-phpunit no-documentation * final provides are sane: php-channel-phpunit = 1.0-1.fc6 * %check is not present; no test suite provide. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear channel..) * no documentation No version for the .xml file, but i think using 1.0 is OK. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review