Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=700199 Alexander Kurtakov <akurtako@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akurtako@xxxxxxxxxx --- Comment #1 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2011-04-27 15:12:02 EDT --- * Would you please name the package just tomcat instead of tomcat7 ? * Please remove Provides: %{name}-log4j = %{epoch}:%{version}-%{release} we don't need it cause there haven't been tomcat7-log4j . * Please use apache-commons-* names instead of jakarta-commons-* . * Please remove the old changelog * Don't BR/R java-1.6.0 but use java >= 1:1.6.0 , same for java-devel * Don't copy old crap into the new package e.g. # Save the conf, app, and lib dirs # due to rbgz 640686. Copy them to the _tmppath so we don't pollute # the tomcat file structure [ -d %{appdir} ] && %{__cp} -rp %{appdir} %{_tmppath}/%{name}-webapps.bak || : [ -d %{confdir} ] && %{__cp} -rp %{confdir} %{_tmppath}/%{name}-confdir.bak || : [ -d %{libdir} ] && %{__cp} -rp %{libdir} %{_tmppath}/%{name}-libdir.bak || : You're not sponsored, right? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review