Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694287 --- Comment #37 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-04-27 09:28:34 EDT --- (In reply to comment #36) > (In reply to comment #33) > > (In reply to comment #28) > > > - Add -p to invocation of cp for installation of header files to preserve the > > > timestamps on the files > > > > This is already recursive. Would it be appropriate to just use -a here? > > Yes Done. > (In reply to comment #35) > <snip> > > > openCOLLADA.x86_64: E: invalid-soname > > /usr/lib64/libOpenCOLLADABaseUtils.so.0.838.0 libOpenCOLLADABaseUtils.so.svn838 > > The lib files should be installed under the same name as you can find them > under the ./lib dir, actually you can just do: > mkdir -p $RPM_BUILD_ROOT%{_libdir} > cp -a lib/* $RPM_BUILD_ROOT%{_libdir} > > For the so files (still need to also cp the include dirs) from %install since > cmake also puts the needed symlinks, etc. under ./lib. Talking about the > include dirs, you should now no longer install the include dirs for libBuffer, > libftoa and libUTF. > > The %files entry for the so files in the main package then becomes: > > %{_libdir}/lib*.so.svn%{AGE} Shouldn't I just make this "%{_libdir}/lib*"? Otherwise it doesn't pick up the symbolic link .so files. > > > Oh, one other small thing I just noticed, instead of: > %post -n openCOLLADA -p /sbin/ldconfig > > %postun -n openCOLLADA -p /sbin/ldconfig > > You can just write: > %post -p /sbin/ldconfig > %postun -p /sbin/ldconfig > > There is no need for the -n openCOLLADA since that is the main package's name. > > > With all previous fixes + the just cp -a lib thingie I think we're 99% there, > if you can provide a new spec file + srpm I'll check it out and either approve > it right away or make a hopefully small list of things left to fix :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review