Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=696357 --- Comment #4 from Mohamed El Morabity <pikachu.2014@xxxxxxxxx> 2011-04-26 20:58:38 EDT --- Really really sorry for this late answer. I may reconsider my views about system-logos, since there is in fact no generic equivalent of the fedora-logo file in the generic-logos package. So I tried to find an alternative. The proper way to get the logo whatever the distribution may be to refer to start-here; this is by the way the icon grabbed by gnome-panel in GNOME 2. The fedora-logos package contains start-here.* icon files, as symbolink links to fedora-icon.*, in /usr/share/icons/hicolor/, since any theme inherits from the hicolor theme. In Fedora<=14, the default theme used in GNOME was the "fedora" one, based on mist which doesn't provide any start-here icon, so start-here was grabbed in hicolor. generic-logos doesn't provide any start-here.* icon, so the "fallback" GNOME start-here.* icon was used instead (the foot logo). In Fedora 15, it seems the default icon theme is "gnome", which provides its own start-here icon, that is to say the foot logo. Some heuristics to grab a path to the distribution logo whatever the current icon theme may exist. It may be an evolution for this extension, one day ^^. Anyway I'm OK to approve this package as it is currently if you rename it to gnome-shell-extension-fedora-logo, which seems to me finally the most appropriate name according to the guidelines. Be *very* careful also with the GNOME Shell version set in metadata.json: you set the shell-version key to 3.0.0.2 whereas the latest version available of GS in the repos is 3.0.1. As a result, your extension won't work in GS > 3.0.0.2. A workaround would be to set shell-version to 3.0, which seems to work for any GS version 3.0.*. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review