[Bug 632856] Review Request: xinput_calibrator - A generic touchscreen calibration program for X.Org

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632856

--- Comment #4 from Robert Scheck <redhat-bugzilla@xxxxxxxxxxxx> 2011-04-26 18:27:13 EDT ---
Fedora dislikes the usage of %global for %{name}, %{version}, %{release} and
other basic things, because "Name: xinput_calibrator" brings the same result
as "%global name xinput_calibrator", so please correct this accordingly.

There is no need to set %{_prefix} for yourself, because did you ever have a
look to what %configure expands? And there is also no need for the parameters
you added, because of this:

$ rpm --eval '%configure'

  CFLAGS="${CFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic}" ; export
CFLAGS ; 
  CXXFLAGS="${CXXFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic}" ; export
CXXFLAGS ; 
  FFLAGS="${FFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic
-I/usr/lib64/gfortran/modules}" ; export FFLAGS ; 
  ./configure --build=x86_64-unknown-linux-gnu --host=x86_64-unknown-linux-gnu
\
 --program-prefix= \
 --disable-dependency-tracking \
 --prefix=/usr \
 --exec-prefix=/usr \
 --bindir=/usr/bin \
 --sbindir=/usr/sbin \
 --sysconfdir=/etc \
 --datadir=/usr/share \
 --includedir=/usr/include \
 --libdir=/usr/lib64 \
 --libexecdir=/usr/libexec \
 --localstatedir=/var \
 --sharedstatedir=/var/lib \
 --mandir=/usr/share/man \
 --infodir=/usr/share/info
%

If the expansion does not fit for you, your build system is misconfigured or
not set up as it should be.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]