Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Synopsis - Source-code Introspection Tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220393 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-12-28 21:09 EST ------- Well, I must say that there are a lot of issues to be fixed... I didn't check this package fully, only just pointing out what should be fixed. Details are written on http://fedoraproject.org/wiki/Packaging/NamingGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines !! I just glanced at a spec file and only did a quick check, not checked fully ! A. From Summary to %description *Release tag - Use %?dist tag * Source0 - Specify URL * BuildRoot - Check the recommended BuildRoot * Prefix/Vendor - Both are forbidden for Fedora * BuildRequiers - This package cannot be rebuild by mockbuild. Please check the BuildRequires (I attach a mockbuild log) * Isn't the description of License for -idl package is redundant? B. %prep * %setup - %setup stage is not quiet C. %build * Fedora specific compilation flags are not passed (I attach a build log) ------------------------------------------------------------- generating dependencies for tools/display-symbols.cc /bin/sh -ec 'g++ -M -I . -I /home/tasaka1/rpmbuild/BUILD/synopsis-0.9/src -I /home/tasaka1/rpmbuild/BUILD/synopsis-0.9/src/Synopsis/gc/include /home/tasaka1/rpmbuild/BUILD/synopsis-0.9/src/tools/display-symbols.cc | sed "s,display-symbols\\.o[ :]*,tools/display-symbols\\.d tools/display-symbols\\.o : ,g" > tools/display-symbols.d' ------------------------------------------------------------- D. %install * Before installing, $RPM_BUILD_ROOT must be cleaned first. E. %post/%postun * Please do not make this package invoke unnecessary shell process (use "%post -p /sbin/ldconfig") F %files * Usually libraries in %{_libdir} should have sominor (not a blocker, however would you contact upsteam?) * Directory ownership is not proper. For example, %{py_sitedir}/Synopsis/ is not owned by any package. * -devel package with pkgconfig .pc files should have "Requires: pkgconfig" * All documentations should be moved to %{_datadir}/doc/%{name}-%{version} * Perhaps 3 files ------------------------------------------ README COPYING NEWS ------------------------------------------ are installed twice by main and -doc package (these should in main) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review