[Bug 220922] Review Request: geany - a lightweight gtk2 based IDE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geany - a lightweight gtk2 based IDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220922





------- Additional Comments From dakingun@xxxxxxxxx  2006-12-28 18:17 EST -------
Seems you're a new contributor, so you'll need a sponsor. In the meantime, here
are a couple of things (not exhaustive) that needs to be fixed with the spec file;

1. Your package includes a .desktop file, and that needs to be properly install
with desktop-file-install, and include a Buildrequire on desktop-file-utils.
2. Locales needs to be installed using the %find_lang macro.
3. You also likely need another BR on gettext (because of the locales).

Also the Requires on glib, gtk, and pango are not necessary, they are
automatically pulled in by rpm.
I've attached a patch to your spec file that fix these issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]