[Bug 697780] Review Request: rubygem-daemon_controller - A library for implementing daemon management capabilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=697780

--- Comment #1 from Parag AN(àààà) <panemade@xxxxxxxxx> 2011-04-19 10:56:04 EDT ---
Suggestions:
1) Each Ruby package MUST indicate the Ruby ABI version it depends on. Add
following at top lines
   %global rubyabi 1.8
2) missing BR
BuildRequires: ruby(abi) = %{rubyabi}
3) License looks MIT
4) For fedora we don't need buildroot,%clean section and cleaning of buildroot
in %install
5) Please provide direct download link for source to verify its checksum

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]