Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693664 --- Comment #10 from Kevin Fenzi <kevin@xxxxxxxxx> 2011-04-17 19:30:42 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: See below - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. See below - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. See below - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: supybot-gribble.src: W: invalid-url Source0: supybot-gribble-20110404.tar which can be ignored here I guess. It might be good to xz or bz the tar file to make it a bit smaller. 2. The Provides: supybot I am not sure is going to work out... The problem here is that if both are in the repos and both providing the same version of supybot, it could be chancy which one gets pulled in. ;( How about this: Remove the Provides: supybot In the supybot package add: "Conflicts: supybot-gribble" In the various supybot plugin packages: (supybot-fedora, supybot-koji, supybot-meetbot) remove the "Requires: supybot" and replace with: "Requires: /usr/bin/supybot" instead. (would need to get supybot maintainer and plugins maintainers on board). 3. Does this really require all python-twisted packages? Normal supybot only needs python-twisted-core and python-twisted-names Did they add deps for news/words/lore/conch/runner? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review