Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=675557 --- Comment #8 from BjÃrn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> 2011-04-17 09:16:48 EDT --- This isn't a complete review yet, but here are some things that need to be addressed:  When you package a snapshot from Subversion, there should still be a normal release number before the so-called alphatag, for example "Release: 1.20110326svn%{?dist}". https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages  If you think it's better to have "http://Adaforge.qtAda.com"; than "http://Adaforge.qtAda.com/cgi-bin/tracker.fcgi/matreshka"; in the URL field, then please explain why you think so. I think the latter is better because it points directly to a page about the Matreshka project.  All the -devel subpackages should be in the group Development/Libraries, not System Environment/Libraries.  Many of the dependencies between the subpackages lack "%{?_isa}". As far as I can see all of these dependencies are architecture-specific, so "%{?_isa}" should be used.  The -devel subpackages should have "Requires: fedora-gnat-project-common >= 2", not "BuildRequires". Only the base package should have "BuildRequires: fedora-gnat-project-common >= 2". There's no need to repeat build-time dependencies in subpackages as they're all built together in one go.  matreshka-sql-sqlite gets an automatic dependency on libsqlite3.so.0, so the explicit dependency on sqlite is unnecessary and should be removed. Quoting the guidelines: "Packages must not contain explicit Requires on libraries except when absolutely necessary. When explicit library Requires are necessary, there should be a spec file comment justifying it." https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires  Does matreshka-sql-postgresql really depend on the PostgreSQL client programs in the package postgresql? If it only depends on the libraries in postgresql-libs, then the automatic dependency on libpq.so.5 should be sufficient and the explicit dependency should be removed.  You pass GNATFLAGS to Make but there is no such variable in the makefiles. Did you mean GPRBUILD_FLAGS?  I think the "make check" command should probably be in a %check section rather than in the %build section.  No package owns the directory /usr/include/matreshka. Some tips, just in case you didn't know:  You can write "%make_install" instead of "make install DESTDIR=%{buildroot}" (but be careful so that you don't write "%makeinstall" by mistake).  You can add translations of the summary and description fields as "Summary(ru)" and "%description -l ru". Look at the PragmARC spec as an example: http://pkgs.fedoraproject.org/gitweb/?p=PragmARC.git;a=blob;f=PragmARC.spec;h=78486a757cb2bdafe0628abb09cf2de290979aa4;hb=HEAD -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review