Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690038 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #2 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-04-16 03:33:11 EDT --- I agree that the library must get a valid soname, escpecially as previous releases had one. Here are some additional notes: - adapt Source0 according to http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net => drop "project" from the path - Add a comment about what the patch does. You should also ask upstream to apply the patch to the sources http://fedoraproject.org/wiki/PackagingGuidelines#All_patches_should_have_an_upstream_bug_link_or_comment - the devel package contains a lot of unused directories that should be dropped: %{_includedir}/ompl/CMakeFiles and below - please be more verbose in %files: %{_libdir}/*.so => %{_libdir}/libompl.so %{_includedir}/* => %{_includedir}/%{name}/ - As BuildRoot is missing, you probably don't intend to build the package for EPEL < 6. Thus, also drop the %clean section (not required any longer). - The tarball contains Python bindings for the library. You should think about adding them to a python subpackage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review