Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694651 Golo Fuchert <packages@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |packages@xxxxxxxxxx --- Comment #1 from Golo Fuchert <packages@xxxxxxxxxx> 2011-04-15 18:32:16 EDT --- Dear Steve, I had a look at your spec file and I don't think that there are major problems, however I need to have a closer look at it. Meanwhile I have two comments: - Presumably the % won't make trouble, on the other hand, is the link really necessary? I mean the point is that you described why the patches are needed and that upstream knows about them, in my opinion this should be sufficient. And we can slip the "ugly" % - You wrote in the description: "The code is a constructed as a C++ library for maximal versatility and openness." Probably there is an 'a' too much. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review