Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692543 --- Comment #5 from Kim B. Heino <b@xxxxxxxx> 2011-04-15 09:15:15 EDT --- > sawfish.x86_64: E: non-executable-script > /usr/share/sawfish/1.8.0/lisp/sawfish/cfg/main.jl 0644L /bin/sh cfg/main.jl is part of runtime library (mode 644 is correct there) and also the source code for sawfish-config (and thus the #!/bin/sh). I added sed line to strip #!/bin/sh from main.jl after installing it. > sawfish.x86_64: W: devel-file-in-non-devel-package /usr/bin/sawfish-config > > ^^^ I suspect that this should be omitted however I'm not sure. Could you > please clarify this? sawfish-config is a bit badly named GUI configurator for Sawfish. It's not devel config script. I added a note about this to the spec. > + The -devel package requires the base package using a fully versioned > dependency: Requires: %{name} = %{version}-%{release} This one was also fail. Fixed. > - The package includes a %{name}.desktop file, and this file must be properly > installed with desktop-file-install in the %install section. I added sawfish-1.8.0-desktop.patch (already sent upstream) and desktop-file-validate to install. Updated files: Spec URL: http://b.bbbs.net/sawfish/sawfish.spec SRPM URL: http://b.bbbs.net/sawfish/sawfish-1.8.0-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review