Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691818 Avesh Agarwal <avagarwa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(avagarwa@xxxxxxxx |needinfo?(mitr@xxxxxxxxxx) |om) | --- Comment #4 from Avesh Agarwal <avagarwa@xxxxxxxxxx> 2011-04-14 14:07:49 EDT --- (In reply to comment #3) > Thanks for the update. > > blocker: > (In reply to comment #2) > > (In reply to comment #1) > > > * Source0: points to a HTML page. > > > If it is possible to use something similar to > > > https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net to get a > > > direct URL to the tarball, this should be done. This problem is not a blocker > > > if no such option exists, obviously. > > > > Can you please check again, because for me, it points to the file and lets me > > download the package? > > This is what I get: > > $ wget 'http://sourceforge.jp/projects/openpts/downloads/51233/openpts-0.2.3.tgz' > ... > > --2011-04-14 18:35:32-- http://sourceforge.jp/projects/openpts/downloads/51233/openpts-0.2.3.tgz/ > > Length: unspecified [text/html] > > Saving to: âindex.htmlâ > ... and the file indeed contains HTML. > > Are you seeing something different? Is it possible that the behavior depends > on the location of the client? > > I am seeing same behaviour with wget. However, if you try to download by clicking on the link that takes a bit of time before it asks you to save the file. Not sure if this is the reason that wget can not download and outputs this error "Length: unspecified [text/html]". Anyway that is the only upstream link I have right now. Please let me know if this is OK to go ahead. > non-blocker: > > > * Including the documenation from doc/ would probably be useful to users. > > > Please also consider including ChangeLog in %doc. > > > > Fixed. > I was thinking more of the manuals; the .eps files are included in the .tex > files and probably not intended to be shipped stand-alone. It seems that the > manuals are not built by default. You are right and since *.tex are not compiled to get pdf or eps, I did not want to include them. If you want, I can remove *.eps. Although I though that something is better than nothing ;-) . Again, please let me know as the above things are not blocker, then is it OK to get ahead with the review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review