Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690360 --- Comment #9 from Justin Morgan <jpmorgan@xxxxxxxxxxxxxxxxxxx> 2011-04-12 19:50:11 EDT --- (In reply to comment #8) > Justin, you should be using upstream's tarballs directly (pristine sources) and > do any stripping/processing in your %prep section. There's two reasons for > this: first, it relieves you of the responsibility of serving that tarball > indefinitely, and secondly, it makes it easier to see how the software is > different from the upstream version (or confirm that it is not). > > Either list two sources (e.g., Source0 and Source1) with the URLs for each of > the tarballs, or separate this into two packages, one for the reg-server and > one for the sync-server. Whether it makes sense to go with one package (and two > sources) or two packages is best determined by the answer to this question: is > there any foreseeable circumstance under which you would use one server but not > the other? > > My suggestion about aliases was this: you want to provide the 'least surprise' > to the sysadmin installing your package. I recommend that the Alias lines in > the httpd weave.conf file be commented out (have a '#' at the start of each > line) so that the weave server doesn't automatically start serving as soon as > it is installed (or more likely and worse yet: it doesn't start serving when > installed, but does start installing after the next boot or httpd restart). > After all, the sysadmin has to configure the DB connection, and may also want > to do virtual host configuration, etc. In your README, include instructions to > uncomment those lines *after* the DB configuration has been performed. > > (Note that other web app packages such as mediawiki take this approach). Hello Chris, The package has been updated to use the Mercurial upstream sources (in addition to tag-date version). I've also as you suggested comment out the weave conf and updated the readme to instruct the installer how to enable Weave services. weave-20110314-1 SPEC: http://matrix.senecac.on.ca/~jpmorgan/SPECS/weave.spec SRPM: http://matrix.senecac.on.ca/~jpmorgan/SRPMS/weave-20110314-1.fc14.src.rpm RPM: http://matrix.senecac.on.ca/~jpmorgan/RPMS/weave-20110314-1.fc14.noarch.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review