[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=695022

Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian@xxxxxxxxxxxxxxxxx

--- Comment #3 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2011-04-11 03:09:37 EDT ---
Just some quick comments:

- The website and the LICENSE.txt claims that the license is LGPL and not GPL.
- There are examples in the source. Wouldn't it be a good idea to put those
examples in a subpackage?
- The '%{!?python_sitearch:...' line is not needed.
- I don't think that console.py needs 755. Removing the shebang can calm
rpmlint down.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]