Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693664 --- Comment #4 from Kevin Fenzi <kevin@xxxxxxxxx> 2011-04-10 18:21:48 EDT --- A few questions actually before I start the full review: Why the +gribble in Version? Why not just 0.83.4.1 ? This is a snapshot, so might be best to use: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages For release... I think 'supybot-gribble-0.83.4.1-0.1.20110410git' would make sense? Also, IMHO, no need to use: %{__install} just use install Also, the Conflicts is something to avoid. ;( Could we rename the bin 'supybot-gribble' ? Is that the only place it really conflicts here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review