Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=694994 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #3 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-04-10 03:12:59 EDT --- > [!] The License field in the package spec file must match the actual license > *** source includes header comments from ZynAddSubFX stating GPLv2+ The license situation is indeed pretty unclear here: - files in src/DSP: licensed under GPLv2 only - files in src/MusicIO and src/main.c: licensed under GPLv3+ Since GPLv2 and GPLv3+ are incompatible, the package can't be distributed this way. Adam, you should ask upstream to clarify the license and to update the copyright info in the source files accordingly. > [!] A Fedora package must not list a file more than once in the spec file's > %files listings > *** You only require %{_datadir}/%{name} - it encompasses sub-directories Listing %{_datadir}/%{name}/banks/ and %{_datadir}/%{name}/presets/ separately is fine. %{_datadir}/%{name}/ would also be valid but has no advantages over the more explicit variant. Actually, being more explicit is usually better and might prevent packaging of unwanted files. > [!] GUI apps must include a %{name}.desktop file, properly installed with > desktop-file-install in the %install section > *** Gnome uses "Comment" whereas KDE uses "GenericName". Should these be the > same? No. According to the desktop file spec (http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html), GenericName should describe the type of the application while Comment contains a toolip text. The spec says: "The value [of Comment] should not be redundant with the values of Name and GenericName." This wouldn't be a blocker, though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review