Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Math-Stats - Classes to calculate statistical parameters Alias: pear-Math-Stats https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218232 ------- Additional Comments From josef@xxxxxxxxxxxxxx 2006-12-27 16:20 EST ------- Ok everything looks good, here is my review check list. review check: -rpmlint output: [jwhiter@dhcp59-101 ~]$ rpmlint /home/jwhiter/redhat/RPMS/noarch/php-pear-Math-Stats-0.9.0-0.1.beta3.noarch.rpm [jwhiter@dhcp59-101 ~]$ - package is named according to the php package naming guidelines - spec file name matches %{name} - package meets package guidlines - package is licensed with appropriate open source license - license feild matches actual license - license is in %doc - license file is written in american english - spec file is legible - sources match upstream ffc0b653e5e2985113262a5299ebe69b Math_Stats-0.9.0beta3.tgz - package successfully compiled on fc6 x86_64 box - buildrequires makes sense and everything required is present - no locales - no shared libraries - not relocatable - owns all directories it creates - no duplicates in %files - permissions set properly - contains a %clean section - uses macros consistently - contains code - no large documentation - files in %doc do not affect runtime - no header files or static libraries - no pkgconfig files - no dynamic libraries provided by package, no need for -devel package - no .la files - not a GUI application - does not own files or directories owned by other packages sorry about the rpmlint problem before, I hadn't run fedora-buildrpmtree on the box I was building on. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review