Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: powerdns - A modern, advanced and high performance authoritative-only nameserver Alias: powerdns https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219973 ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2006-12-27 15:54 EST ------- Thanks for the review Kevin, > 1. The upstream tar is 'pdns' and their shipped spec file makes a 'pdns-static' > package. Should this package be called 'pdns' instead of 'powerdns' ? Changed it to pdns, althought I'm not entirely happy about it. Most users will try to "yum install powerdns". > 2. Doesn't build on x86_64 under mock. Looks like they have a hard coded > check for mysql libs using /usr/lib: Changed to %{_libdir}/mysql, but I can't test if that works. Can you give it a try? 3. You should probably have your Requires for the subpackages also require the release, ie: Fixed. 4. Why the ldconfig calls in post/postun? Left them in by accident, now fixed. New files: http://rubenkerkhof.com/packages/powerdns/pdns.spec http://rubenkerkhof.com/packages/powerdns/pdns-2.9.20-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review