Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692466 --- Comment #7 from Marek Goldmann <mgoldman@xxxxxxxxxx> 2011-04-08 14:43:38 EDT --- (In reply to comment #6) > The "find %{buildroot}%{geminstdir}/bin -type f | xargs chmod a+x" is not > required IMO. Checked, confirmed, removed. > * Licensing > - What is the reason for "and LGPLv2"? I see everywhere mentioned just MIT The setup.rb file has this license. Moved the license to -doc package, see below. > * Test suite > - It would be nice if you could execute the testsuite during build process. Agree. I looked at the tests and it failed for me locally, I tried to find the workaround to create a patch, but it can take more time than I want to spend on this. > * setup.rb could be move into -doc subpackage, since it is not essential > for runtime Agree and done. Updated files: Spec URL: http://goldmann.fedorapeople.org/package_review/rubygem-kwalify.spec SRPM URL: http://goldmann.fedorapeople.org/package_review/rubygem-kwalify-0.7.2-3.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review