Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590355 Terje RÃÂsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #19 from Terje RÃÂsten <terjeros@xxxxxxxxxxxx> 2011-04-07 13:33:49 EDT --- ok rpmlint - some warning safe to ignore. ok naming (name, spec and version) ok legal ok LICENSE in %doc *) ok source tarball: sha256sum golly-2.2-src.tar.gz* cf7fbfd3df3c4cefcd7c4cc881011b2128f7255aacb6c79e93b7f10d3640abc2 golly-2.2-src.tar.gz cf7fbfd3df3c4cefcd7c4cc881011b2128f7255aacb6c79e93b7f10d3640abc2 golly-2.2-src.tar.gz.1 ok builds fine in koji ok dirs, perms, ownes and utf-8 ok macro usage ok .desktop file (with desktop-file-validate) ok optflags used during build *) LICENSE says GPLv2, but license headers in code is GPLv2+. With legal stuff ok, I don't find any serious issues here. The package golly is APPOVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review