Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690282 --- Comment #17 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2011-04-07 04:51:41 EDT --- Other obvious things: 1. Don't install versioned jars and javadoc. 2. Drop %clean and buildroot clean in the beginning of install section it's done automatically by rpm now. 3. Remove the empty post/postun 4. Drop the buildroot definition, it doesn't do anything nowadays. 5. Don't require java-1.6.0-openjdk-devel >= 1:1.6 use java-devel >= 1:1.6, this allows other 1.6 capable jvms to be used. 6. javadoc subpackage installs into %{_javadocdir} but doesn't require jpackage-utils which provides it Once the build issues and these problems are fixed I'll do the official review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review