Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688056 Arun SAG <sagarun@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #12 from Arun SAG <sagarun@xxxxxxxxx> 2011-04-06 12:50:25 EDT --- [+] OK [X] NOT OKAY [?] Investigate the issue before committing the package [-] NA [+] Package meets naming and packaging guidelines [+] Spec file matches base package name. [+] Spec has consistent macro usage. [+] Meets Packaging Guidelines. [+] License [+] License field in spec matches [+] License file included in package [+] Spec in American English [+] Spec is legible. [+] Sources match upstream [zer0c00l@gnubox SPECS]$ md5sum ~/Downloads/sir_2.1.1.tar.gz bbb0526a8b828379449468066d166e04 /home/zer0c00l/Downloads/sir_2.1.1.tar.gz [zer0c00l@gnubox SPECS]$ -- done [-] Package needs ExcludeArch [+] BuildRequires correct [+] Spec handles locales/find_lang [-] Package is relocatable and has a reason to be. [+] Package has %defattr and permissions on files is good. [-] Package has a correct %clean section. [-] Package has correct buildroot [+] Package is code or permissible content. [-] Doc subpackage needed/used. [+] Packages %doc files don't affect runtime. [-] Headers/static libs in -devel subpackage. [-] Spec has needed ldconfig in post and postun [-] .pc files in -devel subpackage/requires pkgconfig [-] .so files in -devel subpackage. [-] -devel package Requires: %{name} = %{version}-%{release} [-] .la files are removed. [+] Package is a GUI app and has a .desktop file [+] Package compiles and builds on at least one arch. http://koji.fedoraproject.org/koji/taskinfo?taskID=2979037 [+] Package has no duplicate files in %files. [+] Package doesn't own any directories other packages own. [+] Package owns all the directories it creates. [?] rpmlint output [zer0c00l@gnubox sir]$ rpmlint ~/rpmbuild/RPMS/i686/sir-2.1.1-3.fc14.i686.rpm sir.i686: W: no-manual-page-for-binary sir 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [zer0c00l@gnubox sir]$ rpmlint ~/rpmbuild/RPMS/i686/sir-debuginfo-2.1.1-3.fc14.i686.rpm sir-debuginfo.i686: W: hidden-file-or-dir /usr/src/debug/sir/.moc sir-debuginfo.i686: W: hidden-file-or-dir /usr/src/debug/sir/.moc sir-debuginfo.i686: W: hidden-file-or-dir /usr/src/debug/sir/.ui sir-debuginfo.i686: W: hidden-file-or-dir /usr/src/debug/sir/.ui 1 packages and 0 specfiles checked; 0 errors, 4 warnings. Check the hidden-file-or-dir warning, ask the upstream about the purpose of their existence before committing the package. SHOULD Items: [+] Should build in mock. [+] Should build on all supported archs [+] Should function as described. [-] Should have sane scriptlets. [-] Should have subpackages require base package with fully versioned depend. [+] Should have dist tag [+] Should package latest version [-] check for outstanding bugs on package. (For core merge reviews) XXX APPROVED XXX -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review