Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: crystal-clear - Crystal Clear KDE Icon set https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219962 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From panemade@xxxxxxxxx 2006-12-26 23:59 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM - rpmlint is NOT for RPMS but I found them harmless. + source files match upstream. adb7962b585c8ad12adc3b82246edb35 CrystalClear.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. - But License text is NOT included in package. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage exists + no .la files. + no translations are available + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + icon set installed successfully. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review