Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693677 Marcela MaÅlÃÅovà <mmaslano@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #4 from Marcela MaÅlÃÅovà <mmaslano@xxxxxxxxxx> 2011-04-05 11:19:21 EDT --- (In reply to comment #3) > (In reply to comment #2) > > - rpmlint OK > > rpmlint avl-* > > avl.src: W: name-repeated-in-summary C AVL > > avl.x86_64: W: name-repeated-in-summary C AVL > Ok. > No, it isn't ... âAVL tree manipulation libraryâ, AVL here describes the type > of trees managed, not the name of the package. > > > avl-devel.x86_64: W: no-documentation > > Well, there just isn't any documentation available for -devel. The only > non-code files are README, and COPYING, which are included in the main package. > > > - package must be licensed with Fedora approved license ? > > - license field must match actual license ? > > > > License: you are providing license files with LGPLv3, but it's licensed as > > LGPLv2. > > Looks like LGPLv2 to me. In updated version are not sources with definition of LGPLv3, so it's okay now. > > > Defining buildroot, rm -rf and clean section are not necessary for Fedora. > > Yes, but this is supposed to be build on RHEL as well (eventually for > forked-daapd server). I am lazy, I would love to have one spec for both. Ok. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review