Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request:gpodder - Podcast receiver/catcher written in Python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220730 bdpepple@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From bdpepple@xxxxxxxxxxxxx 2006-12-26 17:11 EST ------- MD5Sum: 8c58c613d049bd2387e09876c574ebf9 gpodder-0.8.0.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All necessary BuildRequires listed. * Files have appropriate permissions and owners * Rpmlint produces no warnings or errors. * Package builds in Mock fine. * Package installs and uninstalls cleanly on FC6 * Package seems to work fine, based on a quick test. Minor Items that should be fixed before building in FE: * Drop the 'X-Fedora-Extras' category from the desktop file. It was recently decided to drop the 'X-Fedora' & 'X-Fedora-Extras' categories. Refer to the example at http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755 * Drop the Requires on Python, since it is redundant. The BR on python-devel will provide python(abi) = 2.4 automatically. Refer to your build logs for verification. Minor: * Close button on about window does not work. This isn't a blocker, but probably at a minimum should be reported upstream. +1 APPROVE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review