Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691972 Ding-Yi Chen <dchen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #9 from Ding-Yi Chen <dchen@xxxxxxxxxx> 2011-04-04 21:50:21 EDT --- MUST: + rpmlint output is acceptable. + Package meets naming and packaging guidelines. + Package meets licensing guidelines, and match the source license. + Source files match upstream. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + BuildRoot is proper. + BuildRequires are proper. + Requires are proper. + %install starts with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) + %clean contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT) + locale is handle by %find_lang. + %doc files present. + %doc files do not interfere runtime application. + Macros are consistently used. + Package builds in koji. + Package contains code or permissible content. + Package installed properly. + No system library is bundled. + Not relocatable, unless proper justification is presented. + %files section must include a %defattr(...) line, and file permissions are correct. + No duplication in %files + File names are in valid UTF-8. + Own all directory it creates. + Files or directories are not owned by other packages. + Large documentation files goes in a -doc subpackage. + Static libraries in -static package. SHOULD: + License text are in separate files. + Translations for supported non-English languages if available. + Package build in mock. + Package can build in all supported architectures. + Package runs properly. + Scriptlets are sane. + No direct files dependencies, unless they are in either /etc, /bin, /sbin, /usr/bin, or /usr/sbin - Have man pages for each binary You may consider adding man pages for your packages. But it's not a blocker of review. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review