Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642592 --- Comment #13 from VÃt Ondruch <vondruch@xxxxxxxxxx> 2011-04-04 09:35:59 EDT --- * License - according to macaddr rubyforge home page (http://rubyforge.org/projects/codeforpeople/) the gem is licensed just under Ruby license. - You should encourage upstream to add license file: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text * Cleaning - "rm -rf %{buildroot}" at the top of %install, %clean section are no longer needed: https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean * Splitting out document files - Please consider to create -doc subpackage and move the %{gemdir}/doc/%{gemname}-%{version} directories into -doc * Rpmlint - incoherent-version-in-changelog 1.0.0-1 ['1.0.0-2.fc15', '1.0.0-2'] - Please fix the revision in changelog. Koji build looks fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=2971863 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review