Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=693131 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-04-03 09:46:25 EDT --- Here are a couple of initial comments: - The license seems to be GPLv3 only because there's no hint about later versions. Please also ask upstream to add the missing copyright headers to the source files as requested by the GPL. - Add a short comment about what the patch does. - Drop BR: gcc-c++. It's always present in the build environment. See http://fedoraproject.org/wiki/PackagingGuidelines#Exceptions_2 - Drop the GTK icon cache scriptlets. They are only needed if you put something into or below %{_datadir}/icons/hicolor. - Drop INSTALL from %doc. It's not of much use in a binary package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review