Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: doclifter - lifts man pages and other troff-based markups to XML-DocBook https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220736 ------- Additional Comments From bugs.michael@xxxxxxx 2006-12-26 04:08 EST ------- $ manlifter Traceback (most recent call last): File "/usr/bin/manlifter", line 599, in ? exec 'import doclifter_test%s' % os.getpid() File "<string>", line 1, in ? ImportError: No module named doclifter_test2931 Current directory, where you create the temporary copy of doclifter, is not in standard module search path list by default. This is because manlifter lives in /usr/bin, and hence /usr/bin is in sys.path, but os.getcwd() is not. You could append it as work-around, however. [...] $ man doclifter looks very damaged at the end in section "Troff Translation" on FC6. [...] Packaging hints: > Requires: python2 Instead you want "Requires: python" (which is v2 since a long time), because your scripts depend on just /usr/bin/python (and /usr/bin/env python) and not /usr/bin/python2. > %install > [ "$RPM_BUILD_ROOT" -a "$RPM_BUILD_ROOT" != / ] && rm -rf "$RPM_BUILD_ROOT" > %clean > [ "$RPM_BUILD_ROOT" -a "$RPM_BUILD_ROOT" != / ] && rm -rf "$RPM_BUILD_ROOT" This is just added obscurity. Useless for many years. In particular, since you do define a custom BuildRoot in your spec file already. rm -rf ${RPM_BUILD_ROOT} is sufficient and nice to the eyes. Btw, it is a myth that the extra check has ever been useful. Unless you've been burnt yourself you will have a hard time finding anybody who has ever set --buildroot=/ while it that was possible. Nowadays, BuildRoot cannot be "/". -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review