Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=690954 --- Comment #5 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2011-04-02 20:21:33 EDT --- Review for 4494cd46098d379815e9df41842df4cd postler-0.1.1-1.fc14.src.rpm OK - MUST: $ rpmlint /var/lib/mock/fedora-14-x86_64/result/postler-* postler.src: W: spelling-error %description -l en_US automagic -> automatic, auto magic, auto-magic postler.x86_64: W: spelling-error Summary(en_US) vala -> lava, val, ala postler.x86_64: W: spelling-error %description -l en_US automagic -> automatic, auto magic, auto-magic postler.x86_64: W: no-manual-page-for-binary postler postler.x86_64: W: no-manual-page-for-binary postler-mbsync 3 packages and 0 specfiles checked; 0 errors, 5 warnings. OK - MUST: named according to the Package Naming Guidelines OK - MUST: spec file name matches the base package %{name} OK - MUST: package meets the Packaging Guidelines OK - MUST: Fedora approved license and meets the Licensing Guidelines: LGPLv2+ FIX - MUST: License field in spec file does not match the actual license OK - MUST: license file included in %doc OK - MUST: spec is in American English OK - MUST: spec is legible OK - MUST: sources match the upstream source by MD5 02e502c9f4a4b92e4ace32d9e268f06d OK - MUST: successfully compiles and builds into binary rpms on x86_64 N/A - MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. OK - MUST: all build dependencies are listed in BuildRequires. OK - MUST: handles locales properly with %find_lang N/A - MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. OK - MUST: Package does not bundle copies of system libraries. N/A - MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package OK - MUST: owns all directories that it creates OK - MUST: no duplicate files in the %files listing OK - MUST: Permissions on files are set properly, includes %defattr(...) OK - MUST: consistently uses macros OK - MUST: package contains code, or permissable content N/A - MUST: Large documentation files should go in a -doc subpackage OK - MUST: Files included as %doc do not affect the runtime of the application N/A - MUST: Header files must be in a -devel package N/A - MUST: Static libraries must be in a -static package N/A - MUST: library files that end in .so are in the -devel package. N/A - MUST: devel packages must require the base package using a fully versioned dependency OK - MUST: The package does not contain any .la libtool archives. OK - MUST: Package contains a GUI application and includes a %{name}.desktop file, and that file is properly validated with desktop-file-validate OK - MUST: package does not own files or directories already owned by other packages. OK - Should: at the beginning of %install, the package runs rm -rf %{buildroot} OK - MUST: all filenames valid UTF-8 SHOULD Items: OK - SHOULD: Source package includes license text(s) as a separate file. N/A - SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. OK - SHOULD: builds in mock. OK - SHOULD: compiles and builds into binary rpms on all supported architectures. WELL - SHOULD: functions as described. OK - SHOULD: Scriptlets are sane. N/A - SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg N/A - SHOULD: no file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin N/A - SHOULD: package should contain man pages for binaries/scripts. Other items: OK - latest stable version OK - SourceURL valid OK - Compiler flags ok OK - Debuginfo complete OK - SHOULD: package has a %clean section, which contains rm -rf %{buildroot} N/A - SHOULD: Packages containing pkgconfig(.pc) files should 'Requires: pkgconfig'. Issues: - License is LGPLv2+ and not LGPLv2 because there is a "or any later version" clause. - The icon should have a different name as explained in comment #4. - Require dexxter once it's in the repo. - Does not build on rawhide: Waf: Entering directory `/builddir/build/BUILD/postler-0.1.1/_build_' [ 1/44] valac: postler/dexter.vala postler/dockmanager.vala postler/elementary-entry.vala postler/postler-accounts.vala postler/postler-accountsetup.vala postler/postler-app.vala postler/postler-attachments.vala postler/postler-bureau.vala postler/postler-cellrenderertoggle.vala postler/postler-client.vala postler/postler-composer.vala postler/postler-content.vala postler/postler-flowbox.vala postler/postler-folders.vala postler/postler-messages.vala postler/postler-reader.vala postler/postler-recipiententry.vala postler/postler-scrolled.vala postler/postler-service.vala postler/postler-shortcuts.vala postler/postler-state.vala postler/postler-viewer.vala -> _build_/default/postler/dexter.c _build_/default/postler/dockmanager.c _build_/default/postler/elementary-entry.c _build_/default/postler/postler-accounts.c _build_/default/postler/postler-accountsetup.c _build_/default/postler/postler-app.c _build_/default/postler/postler-attachments.c _build_/default/postler/postler-bureau.c _build_/default/postler/postler-cellrenderertoggle.c _build_/default/postler/postler-client.c _build_/default/postler/postler-composer.c _build_/default/postler/postler-content.c _build_/default/postler/postler-flowbox.c _build_/default/postler/postler-folders.c _build_/default/postler/postler-messages.c _build_/default/postler/postler-reader.c _build_/default/postler/postler-recipiententry.c _build_/default/postler/postler-scrolled.c _build_/default/postler/postler-service.c _build_/default/postler/postler-shortcuts.c _build_/default/postler/postler-state.c _build_/default/postler/postler-viewer.c ../postler/postler-accounts.vala:69.44-69.44: error: Value must be constant Waf: Leaving directory `/builddir/build/BUILD/postler-0.1.1/_build_' Build failed: -> task failed (err #1): -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review