Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=688183 --- Comment #9 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2011-04-02 17:23:08 EDT --- (In reply to comment #8) > OK. Fixed all of the wrongs (and changed the .desktop file, reported a bug > about this to developer). > Thank you for all. > > ... well, i can't understand "Isn't RPM picking the Requires: automatically?", > sorry. RPM is able to pick the requirements of a package in most cases automatically. Remove the packages named as "Requires:" and see what happens. > $ rpmlint iceplayer.spec > 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint should be run against the packages too. [fab@laptop023 x86_64]$ rpmlint iceplayer* iceplayer.x86_64: E: explicit-lib-dependency libnotify iceplayer.x86_64: W: spelling-error %description -l en_US linux -> Linux iceplayer.x86_64: E: description-line-too-long C iceplayer is a open-source linux music player. It can play music. And it's a free software. iceplayer.x86_64: W: spurious-executable-perm /usr/share/doc/iceplayer-4.0.4/AUTHORS iceplayer.x86_64: W: spurious-executable-perm /usr/share/doc/iceplayer-4.0.4/COPYING iceplayer.x86_64: W: no-manual-page-for-binary iceplayer iceplayer-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/iceplayer-4.0.4-20110318/desktop_lrc.h iceplayer-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/iceplayer-4.0.4-20110318/keybinding.h iceplayer-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/iceplayer-4.0.4-20110318/download.c iceplayer-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/iceplayer-4.0.4-20110318/list.h iceplayer-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/iceplayer-4.0.4-20110318/equalizer.h 2 packages and 0 specfiles checked; 2 errors, 9 warnings. - Source0: http://ekd123.fedorapeople.org/%{name}-%{version}-20110318.tar.gz is wrong. This must point to the upstream location of the source code. - The naming of the package is wrong. Upstream is releasing different version under the same version number but with a new date. Your package must reflect that circumstance. https://fedoraproject.org/wiki/Packaging:NamingGuidelines - desktop-file-validate is not needed. - mimeinfo is for XML files. You don't need this. - There is a skin directory. Have you consider to put those skins in a separate subpackage? - The build of your package failed on Koji http://koji.fedoraproject.org/koji/taskinfo?taskID=2969153 - The interface of iceplayer is in Chinese (i think). At the moment I'm not sure if this will become an issue. I'm not a sponsor. I suggest that you follow https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review