Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676941 --- Comment #5 from Michael Schwendt <mschwendt@xxxxxxxxx> 2011-04-01 12:57:37 EDT --- Some more items: > Requires: gtk2 >= 2.10 > Requires: glib2 >= 2.10 > Requires: libglade2 >= 2.4 > Requires: gettext > Requires: libeiskaltdcpp = %{version}-%{release} https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires For a Fedora Packager it is very important to understand rpmbuild's automatic dependencies on library SONAMEs. > 5) What does %dir do? It includes a directory (and just the dir, not any files within the dir) in the RPM package with proper ownership and permissions. https://fedoraproject.org/wiki/Packaging:UnownedDirectories Under certain circumstances, %dir and recursive inclusion of a directory compete with eachother with regard to adding an entry for the directory to the package. > %files -f %{name}.lang > %{_datadir}/locale/*/LC_MESSAGES/eiskaltdcpp-gtk.mo https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files > %{_mandir}/man1/eiskaltdcpp-gtk.1.gz Acceptable, but please notice that the gzip compression is applied by rpmbuild and may change. So, %{_mandir}/man1/eiskaltdcpp-gtk.1* would be safer. > make install/strip DESTDIR=%{buildroot} Please investigate what this "/strip" here does. > rm -f %{buildroot}/%{_libdir}/libeiskaltdcpp.so.2.2 > rm -f %{buildroot}/%{_datadir}/locale/*/LC_MESSAGES/libeiskaltdcpp.mo Two commands that ask for an explanation in a comment. > %{_datadir}/applications/eiskaltdcpp-gtk.desktop https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files [...] https://fedoraproject.org/wiki/Packaging:Guidelines https://fedoraproject.org/wiki/Packaging:ReviewGuidelines https://fedoraproject.org/wiki/PackageMaintainers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review