Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=677946 --- Comment #4 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-04-01 06:21:32 EDT --- (In reply to comment #3) > Tried to a mock build for Fedora 14. Failed because liblouis-devel >= 2.2.0 > doesn't exist in that release. Maybe mock's yum cache wasn't up-to-date? The latest version of liblouis-devel is present in F14: $ repoquery liblouis-devel liblouis-devel-0:2.2.0-2.fc14.i686 > liblouisutdml.spec:70: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: > line 70) Fixed. > Consider removing buildroot definitions and clean section since they are > superfluous unless you are branching for older EPEL. Dropped the buildroot stuff as I don't intend to build the package for EPEL<6. > Do a comment on top of Provides: bundled(gnulib) = 20091111 explaining it. Done. > Should liblouisutdml-java sub package co-own /usr/share/java or add a requires > on jpackage-utils? Yes, I forgot to add Requires: jpackage-utils. Fixed now. > Might consider whether documents should be part of a separate -docs sub package > depending on how the library is used and which apps are likely to depend on > them. OK, moved all docs to a -doc subpackage. They all contain information for both end-users and developers. > It is helpful to explicitly name the binaries and a brief one liner in the > description of -utils. Helps for users using yum search and yum info Done. > If liblouisutdml is successor to liblouisxml, should the former obsolete the > latter? liblouisxml hasn't been packaged for Fedora, so there's no need to obsolete it. > Could consider adding a brief one liner to the sub package descriptions > describing the functionality of the main package. Done. > Can you explain the purpose of > ln -s %{_javadir}/%{name}.jar %{buildroot}%{_javadir}/j%{name}.jar According to the guidelines, the name of the jar file must be %{name}.jar. However, upstream uses j%{name}.jar. In order to stay compatible with it, I added a symlink with the alternative name. If this is not desired, I'd drop it again. > /usr/bin/lbu_devonly doesn't have a man page and I recommend asking upstream to > add them or add and send them upstream. Running /usr/bin/lbu_devonly in my > Fedora 15 system causes a core dump. Look into that as well. I reported the segfault upstream: http://code.google.com/p/liblouisutdml/issues/detail?id=1 Since this seems to be a serious problem, I've excluded lbu_devonly for now. It also seems to be a utility for developers only not intended for end-users. I'm waiting for a response from the developer about this. Spec: http://mgieseki.fedorapeople.org/liblouisutdml/liblouisutdml.spec SRPM: http://mgieseki.fedorapeople.org/liblouisutdml/liblouisutdml-1.7.0-3.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review