Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226510 --- Comment #21 from Harald Hoyer <harald@xxxxxxxxxx> 2011-04-01 03:38:50 EDT --- (In reply to comment #20) > Cool, thanks! > > Starting over on current rawhide SRPM: > > udev.src:182: W: mixed-use-of-spaces-and-tabs (spaces: line 129, tab: line 182) > The specfile mixes use of spaces and tabs for indentation, which is a cosmetic > annoyance. Use either spaces or tabs for indentation, not both. right.. will fix! > > udev.src: W: invalid-url Source0: > ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/udev-167.tar.bz2 <urlopen > error ftp error: [Errno 111] Connection refused> > The value should be a valid, public HTTP, HTTPS, or FTP URL. huh? loads fine! $ wget ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/udev-167.tar.bz2 --2011-04-01 09:39:27-- ftp://ftp.kernel.org/pub/linux/utils/kernel/hotplug/udev-167.tar.bz2 => `udev-167.tar.bz2.1' Resolving ftp.kernel.org... 130.239.17.4, 199.6.1.164 Connecting to ftp.kernel.org|130.239.17.4|:21... connected. Logging in as anonymous ... Logged in! ==> SYST ... done. ==> PWD ... done. ==> TYPE I ... done. ==> CWD (1) /pub/linux/utils/kernel/hotplug ... done. ==> SIZE udev-167.tar.bz2 ... 594474 ==> PASV ... done. ==> RETR udev-167.tar.bz2 ... done. Length: 594474 (581K) (unauthoritative) .... > > These are the only things not addressed above. > > These are new, and I'm imagining are ok: > > udev.i686: W: devel-file-in-non-devel-package /usr/share/pkgconfig/udev.pc > A development file (usually source code) is located in a non-devel package. If > you want to include source code in your package, be sure to create a > development package. yes, that's needed > > udev.i686: W: cross-directory-hard-link /etc/udev/makedev.d /var/lib/udev > File is hard linked across directories. This can cause problems in > installations where the directories are located on different devices. huh? # Deprecated, but keep the ownership %ghost %dir /var/lib/udev %ghost %dir %{_sysconfdir}/udev/makedev.d/ > > udev.i686: W: no-manual-page-for-binary start_udev > Each executable in standard binary directories should have a man page. that's ok, nobody should use it > > > Otherwise, it looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review