Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libprelude - Prelude library collection https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209214 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-12-25 05:03 EST ------- Well, Compared to http://fedoraproject.org/wiki/Packaging/Guidelines : * Requires - Check the requirement for -devel package. -------------------------------------------------------------- [tasaka1@dhcp158 bin]$ ./libprelude-config --libs -L/usr/lib -lprelude -lgnutls -lgcrypt -lgpg-error -lrt -ldl -------------------------------------------------------------- This usually means that -devel package should require gnutls-devel. * Beware of Rpath - This package fails on rpath checking. ----------------------------------------------------------- + /usr/lib/rpm/find-debuginfo.sh /home/tasaka1/rpmbuild/BUILD/libprelude-0.9.12 extracting debug info from /var/tmp/libprelude-0.9.12-2-root-tasaka1/usr/bin/prelude-adduser extracting debug info from /var/tmp/libprelude-0.9.12-2-root-tasaka1/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/Prelude/Prelude.so extracting debug info from /var/tmp/libprelude-0.9.12-2-root-tasaka1/usr/lib/libprelude.so.2.9.0 extracting debug info from /var/tmp/libprelude-0.9.12-2-root-tasaka1/usr/lib/python2.5/site-packages/_prelude.so 10681 blocks + /usr/lib/rpm/check-rpaths /usr/lib/rpm/check-buildroot ******************************************************************************* * * WARNING: 'check-rpaths' detected a broken RPATH and will cause 'rpmbuild' * to fail. To ignore these errors, you can set the '$QA_RPATHS' * environment variable which is a bitmask allowing the values * below. The current value of QA_RPATHS is 0x0000. * * 0x0001 ... standard RPATHs (e.g. /usr/lib); such RPATHs are a minor * issue but are introducing redundant searchpaths without * providing a benefit. They can also cause errors in multilib * environments. * 0x0002 ... invalid RPATHs; these are RPATHs which are neither absolute * nor relative filenames and can therefore be a SECURITY risk * 0x0004 ... insecure RPATHs; these are relative RPATHs which are a * SECURITY risk * 0x0008 ... the special '$ORIGIN' RPATHs are appearing after other * RPATHs; this is just a minor issue but usually unwanted * 0x0010 ... the RPATH is empty; there is no reason for such RPATHs * and they cause unneeded work while loading libraries * 0x0020 ... an RPATH references '..' of an absolute path; this will break * the functionality when the path before '..' is a symlink * * * Examples: * - to ignore standard and empty RPATHs, execute 'rpmbuild' like * $ QA_RPATHS=$[ 0x0001|0x0010 ] rpmbuild my-package.src.rpm * - to check existing files, set $RPM_BUILD_ROOT and execute check-rpaths like * $ RPM_BUILD_ROOT=<top-dir> /usr/lib/rpm/check-rpaths * * 'check-rpaths' is part of 'rpmdevtools'. * ******************************************************************************* ERROR 0010: file '/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/Prelude/Prelude.so' contains an empty rpath in [] error: Bad exit status from /var/tmp/rpm-tmp.71892 (%install) ----------------------------------------------------------- Prelude.so contains empty rpath and this should be removed. * Timestamps - Please consider to keep timestamps on installed files, especially on text files because * timestamps can show when the files are created and if vendor (like you) have modified the files. This package contain many HTML documents and header files, so keeping timestamps on those files are preferable. For this package, this can be done by ------------------------------------------------------------ make install DESTDIR=%{buildroot} INSTALL="%{__install} -c -p" cp -p AUTHORS ChangeLog README INSTALL LICENSE.README HACKING.README \ ------------------------------------------------------------ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review