Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=692281 --- Comment #7 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-03-31 12:21:00 EDT --- The package looks almost fine now. Just change the permissions of the following files to 0644: hotot/ext/org.hotot.imageupload/entry.js hotot/ext/ext.js $ rpmlint *.rpm hotot.noarch: W: no-documentation hotot.noarch: E: script-without-shebang /usr/share/hotot/ext/org.hotot.imageupload/entry.js hotot.noarch: E: script-without-shebang /usr/share/hotot/ext/ext.js hotot.noarch: W: no-manual-page-for-binary hotot hotot.src: W: invalid-url Source0: hotot-0.9.5-8bd3e1986200.tar.bz2 2 packages and 0 specfiles checked; 2 errors, 3 warnings. All warnings are expected and can be ignored. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. - multiple licensing scenario: LGPLv3+ and LGPLv3 and BSD and GPLv2 [+] MUST: The License field in the package spec file must match the actual license. [.] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ rpmdev-diff -c hotot-0.9.5-8bd3e1986200.tar.bz2 hotot-0.9.5-8bd3e1986200.tar.bz2 is silent [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: When compiling C, C++, or Fortran files, %{optflags} must be applied. [+] MUST: The spec file MUST handle locales properly. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [X] MUST: Permissions on files must be set properly. - set file permissions of hotot/ext/org.hotot.imageupload/entry.js and hotot/ext/ext.js to 0644 [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [.] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file. [+] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [+] MUST: Python eggs must be built from source. They cannot simply drop an egg from upstream into the proper directory. [+] MUST: Python eggs must not download any dependencies during the build process. [+] MUST: If egg-info files are generated by the modules build scripts they must be included in the package. [.] MUST: When building a compat package, it must install using easy_install -m so it won't conflict with the main package. [.] MUST: When building multiple versions (for a compat package) ... [.] SHOULD: A package which is used by another package via an egg interface should provide egg info. [X] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [+] SHOULD: The reviewer should test that the package builds in mock. [.] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: The reviewer should test that the package functions as described. [.] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [.] SHOULD: Your package should contain man pages for binaries/scripts. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review