Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691096 Kevin Fenzi <kevin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #1 from Kevin Fenzi <kevin@xxxxxxxxx> 2011-03-31 08:34:20 EDT --- Hey G. Just a few quick things I noticed to be fixed before I do my review checklist. ;) 1. The spec and Name: should be 'iperf3' here, right? Or are you intending to replace/update the existing iperf package? 2. The version here is not right. You should not have things like 'b4' in version. ;) See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages I think you want: Version: 3.0 Release: 0.0.b4%{?dist} Then when the final 3.0 comes out, Release goes to 1 and it updates correctly from this beta version. If you make changes to packaging before that you can use: Release: 0.1.b4%{?dist} etc. And the update path works. ;) 3. You probibly don't want to ship the static library: http://fedoraproject.org/wiki/PackagingGuidelines#Packaging_Static_Libraries I would suggest removing the .a and header files at the end of %install and then commenting out the -devel subpackage entirely. You could add it back in when/if they have a dynamic library or someone really needs the static one. ;) Anyhow, if you could look at those, I could start a formal review after that. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review