Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691997 Parag AN(àààà) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(àààà) <panemade@xxxxxxxxx> 2011-03-31 01:54:48 EDT --- Review: + koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=2962531 + source verified as (sha1sum) 1cbfffdf8e5f81915642340560fb2ca7c1d08ef5 NanumFont_TTF_ALL.zip 1cbfffdf8e5f81915642340560fb2ca7c1d08ef5 ../SOURCES/NanumFont_TTF_ALL.zip + packaging looks fine. Suggestion 1) If -common subpackage does not contain any files then it should be dropped. 2) Also, NanumPen.ttf and NanumBrush.ttf fonts contain 1.100 version while other fonts have 3.010 version. We can also create versioned subpackages for those 2 fonts. 3) If this is going to be packaged for Fedora 13 onwards then drop %clean section and cleanup of buildroot in %install. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review