Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=676129 --- Comment #8 from Michal Schmidt <mschmidt@xxxxxxxxxx> 2011-03-30 11:09:48 EDT --- Looks quite good to me. I am still worried about the optflags though. I do not think getting them from Qt is sufficient. Consider a situation when standard Fedora optflags change and a mass-rebuild is done to apply the change to all packages. I don't think in such a rebuild anything would guarantee that qconf is built after Qt. So it might end up still using the old optflags. Or a simpler case - someone might reasonably put custom optflags into his ~/.rpmmacros and then rebuild the package expecting his flags to apply. If the build used Qt's optflags instead, it would not work as expected. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review